After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779294 - adaptivedemux: Fix timescale of fragment-start-time
adaptivedemux: Fix timescale of fragment-start-time
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-27 03:14 UTC by Seungha Yang
Modified: 2018-11-03 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adaptivedemux: Fix timescale of fragment-start-time (1.32 KB, patch)
2017-02-27 03:15 UTC, Seungha Yang 		needs-work Details | Review
adaptivedemux: Use nanoseconds timescale for download_start_time (3.02 KB, patch)
2017-03-15 04:03 UTC, Seungha Yang 		none Details | Review

Description Seungha Yang 2017-02-27 03:14:32 UTC 
Use nanoseconds timescale like other fields such as
fragment-{stop,download}-time and manifest-download-{start,stop}
Comment 1 Seungha Yang 2017-02-27 03:15:16 UTC 
Created attachment 346785 [details] [review]
adaptivedemux: Fix timescale of fragment-start-time
Comment 2 Sebastian Dröge (slomo) 2017-03-02 17:18:24 UTC 
Review of attachment 346785 [details] [review]:

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +4257,3 @@
               demux->manifest_uri, "uri", G_TYPE_STRING,
               stream->fragment.uri, "fragment-start-time",
+              GST_TYPE_CLOCK_TIME, stream->download_start_time * GST_USECOND,

Instead of multiplying it with GST_USECOND at every use, maybe just store it in nanoseconds to begin with :)
Comment 3 Seungha Yang 2017-03-15 04:03:49 UTC 
Created attachment 347978 [details] [review]
adaptivedemux: Use nanoseconds timescale for download_start_time

Instead of converting it to other timescale at every use.
Comment 4 GStreamer system administrator 2018-11-03 14:05:02 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/524.