GNOME Bugzilla – Bug 779248
build: don't run aclocal in autogen.sh
Last modified: 2017-02-27 13:18:13 UTC
autoreconf takes care of running aclocal (and other commands) in the right order.
Created attachment 346744 [details] [review] build: don't run aclocal in autogen.sh
Review of attachment 346744 [details] [review]: The autoreconf line needs to be above gtkdocize. Try distcleaning before configuring and you’ll see.
(In reply to Ernestas Kulik from comment #2) > Review of attachment 346744 [details] [review] [review]: > > The autoreconf line needs to be above gtkdocize. Try distcleaning before > configuring and you’ll see. Sorry, I'm missing something. By distclean, if you mean 'make distclean' it is supposed to work only after './configure' (ie, only if there is a Makefile). Or is this something else? I don't find any related documentation in manpage or --help of gtkdocize.
(In reply to Mohammed Sadiq from comment #3) > (In reply to Ernestas Kulik from comment #2) > > Review of attachment 346744 [details] [review] [review] [review]: > > > > The autoreconf line needs to be above gtkdocize. Try distcleaning before > > configuring and you’ll see. > > Sorry, I'm missing something. By distclean, if you mean 'make distclean' it > is supposed to work only after './configure' (ie, only if there is a > Makefile). Or is this something else? > > I don't find any related documentation in manpage or --help of gtkdocize. Oh, you’re not using jhbuild, sorry about that. git clean -xdf, then. gtkdocize copies into the macro dir, which doesn’t exist in the repo and is created by aclocal/autoreconf.
It also seems that Javier Jardón has been trying to add GTK-Doc support to autoreconf. I don’t know what’s the status of the patch, but it hasn’t been merged yet.
Created attachment 346746 [details] [review] build: don't run aclocal in autogen.sh autoreconf takes care of running aclocal (and other commands) in the right order.
Comment on attachment 346746 [details] [review] build: don't run aclocal in autogen.sh Sorry. this seems again wrong.
Created attachment 346747 [details] [review] build: don't run aclocal in autogen.sh autoreconf takes care of running aclocal and other commands in the right order.
Created attachment 346748 [details] [review] build: don't run aclocal in autogen.sh autoreconf takes care of running aclocal and other commands in the right order. Also, removing aclocal saves around 40 seconds (on my machine) for running autogen.sh
Created attachment 346749 [details] [review] autogen.sh: don't run aclocal autoreconf takes care of running aclocal and other commands in the right order. Also, removing aclocal saves around 40 seconds (on my machine) for running autogen.sh
Review of attachment 346749 [details] [review]: Yup, just what we need, thanks!
Created attachment 346757 [details] [review] autogen.sh: don't run aclocal autoreconf takes care of running aclocal and other commands in the right order. Also, removing aclocal saves around 40 seconds (Thanks to Ernestas Kulik for testing) when running autogen.sh Saying false statements are truely sin which I should always avoid, and credit the right person.
Review of attachment 346757 [details] [review]: I trusts you on this one, these autotools always messes with me :)
(In reply to Carlos Soriano from comment #13) > I trusts you on this one, these autotools always messes with me :) Oh. Hopefully we can revert this if someone complains. :) And soon we are going to use meson by default . So this won't be a big issue.
Attachment 346757 [details] pushed as 753e9d8 - autogen.sh: don't run aclocal