After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779221 - templates: don't run aclocal in autogen.sh
templates: don't run aclocal in autogen.sh
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: templates
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-25 15:34 UTC by Mohammed Sadiq
Modified: 2017-02-27 01:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
templates: don't run aclocal in autogen.sh (972 bytes, patch)
2017-02-25 15:34 UTC, Mohammed Sadiq
committed Details | Review
templates: fix autogen.sh with '--enable-gtk-doc' (932 bytes, patch)
2017-02-27 01:11 UTC, Mohammed Sadiq
committed Details | Review

Description Mohammed Sadiq 2017-02-25 15:34:43 UTC
autoreconf already runs the required commands (including aclocal)
in the right order.
Comment 1 Mohammed Sadiq 2017-02-25 15:34:51 UTC
Created attachment 346709 [details] [review]
templates: don't run aclocal in autogen.sh
Comment 2 Christian Hergert 2017-02-25 17:58:32 UTC
Review of attachment 346709 [details] [review]:

lgtm
Comment 3 Christian Hergert 2017-02-25 18:20:15 UTC
Attachment 346709 [details] pushed as 4a012b8 - templates: don't run aclocal in autogen.sh
Comment 4 Mohammed Sadiq 2017-02-27 01:11:38 UTC
Created attachment 346783 [details] [review]
templates: fix autogen.sh with '--enable-gtk-doc'

an m4 directory is required for gtkdocize to work


This fixes the side effect of the last patch.
Comment 5 Christian Hergert 2017-02-27 01:12:57 UTC
Review of attachment 346783 [details] [review]:

fun