After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779178 - tests: Search-engine and directory-access tests segfault
tests: Search-engine and directory-access tests segfault
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-24 13:15 UTC by Jan Tojnar
Modified: 2017-02-24 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Fix segfaults of search-engine and directory-access tests (1.88 KB, patch)
2017-02-24 13:17 UTC, Jan Tojnar 		none Details | Review
tests: Fix directory extensions points (1.85 KB, patch)
2017-02-24 13:20 UTC, Jan Tojnar 		committed Details | Review

Description Jan Tojnar 2017-02-24 13:15:31 UTC 
When trying to run a tests test-nautilus-search-engine and test-nautilus-directory-access segfault.
Comment 1 Jan Tojnar 2017-02-24 13:17:15 UTC 
Created attachment 346634 [details] [review]
tests: Fix segfaults of search-engine and directory-access tests

In 7840b533e2, `nautilus-directory-provider` extension point was added
to the code paths used by the tests. When glib is asked for extensions,
it assumes the extension point is registered so it segfaults.

This patch registers the extension point before the tests are run.
Comment 2 Carlos Soriano 2017-02-24 13:19:20 UTC 
Review of attachment 346634 [details] [review]:

The code looks good!
The commit message tittle is too long, you can use something like: "tests: Fix directory extensions points"
Comment 3 Jan Tojnar 2017-02-24 13:20:51 UTC 
Created attachment 346635 [details] [review]
tests: Fix directory extensions points

In 7840b533e2, `nautilus-directory-provider` extension point was added
to the code paths used by the tests. When glib is asked for extensions,
it assumes the extension point is registered so it segfaults.

This patch registers the extension point before the tests are run.
Comment 4 Carlos Soriano 2017-02-24 13:25:30 UTC 
Review of attachment 346635 [details] [review]:

+1 thanks!
Comment 5 Carlos Soriano 2017-02-24 13:31:10 UTC 
Attachment 346635 [details] pushed as 5488240 - tests: Fix directory extensions points