After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779147 - Inspector: Use Title Case for labels & menu items
Inspector: Use Title Case for labels & menu items
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-02-23 18:37 UTC by Daniel Boles
Modified: 2017-03-02 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Inspector: Use Title Case for labels & menu items (9.03 KB, patch)
2017-02-23 18:37 UTC, Daniel Boles
committed Details | Review

Comment 1 Daniel Boles 2017-02-23 18:37:48 UTC
Created attachment 346594 [details] [review]
Inspector: Use Title Case for labels & menu items

https://developer.gnome.org/hig/stable/writing-style.html.en
Comment 2 Matthias Clasen 2017-02-23 19:07:59 UTC
Review of attachment 346594 [details] [review]:

sure
Comment 3 Daniel Boles 2017-02-23 19:14:34 UTC
Attachment 346594 [details] pushed as ad5ff5f - Inspector: Use Title Case for labels & menu items
Comment 4 Piotr Drąg 2017-02-23 19:22:00 UTC
I *really* don’t think this patch should go to a stable branch.

https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=85f2c5f8301ab70418e488e8e058decb9121899a
Comment 5 Daniel Boles 2017-02-23 19:23:48 UTC
Reverted, sorry, was on autopilot and didn't consider the string freeze.
Comment 6 Emmanuele Bassi (:ebassi) 2017-02-23 19:32:04 UTC
We're still in string announcement, and there won't be a 3.24 branch, so I don't see the issue in backporting to gtk-3-22.
Comment 7 Piotr Drąg 2017-02-23 19:42:26 UTC
gtk-3-22 would be affected by last release cycle’s freezes, if GTK+ was obligated to follow i18n freezes at all. It is not, but I don’t see enough value in this commit to justify backporting and making translators do additional work. We have a lot of string improvements in master already that we did not backport.
Comment 8 Matthias Clasen 2017-02-27 13:39:46 UTC
we can tweak the patch to pick up the existing translations
Comment 9 Matthias Clasen 2017-02-27 13:40:35 UTC
gtk is in a bit of a special situation currently, since 3.22 is the final 3.x branch, so we need to allow ourselves a little bit of leeway to put improvements on that branch.
Comment 10 Matthias Clasen 2017-03-02 13:16:14 UTC
but anyway, probably not worth doing that extra work here