After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779087 - VPN DNS servers discarded when using systemd-resolved DNS
VPN DNS servers discarded when using systemd-resolved DNS
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
1.6.x
Other Linux
: Normal major
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 782597 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-02-22 17:46 UTC by Daniel Ramos
Modified: 2017-05-19 08:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] dns/resolved: consider configuration from unmanaged devices (1.33 KB, patch)
2017-02-24 13:35 UTC, Beniamino Galvani
none Details | Review

Description Daniel Ramos 2017-02-22 17:46:54 UTC
In Ubuntu 17.04 (Zesty Zapus) NetworkManager has switched from DNSMasq to Systemd-resolved for DNS. Unfortunately this broke DNS resolution on my VPN connection. I'm using the network-manager-l2tp VPN plugin. 

After investigating - it seems the VPN connection's DNS server information is discarded when using the systemd-resolved DNS plugin. Since the PPP interface the VPN creates is not "managed" by NetworkManager, the systemd-resolved plugin ignores DNS servers from that interface entirely. 
https://github.com/NetworkManager/NetworkManager/blob/44ecb41/src/dns/nm-dns-systemd-resolved.c#L121

The DNSMasq plugin does not exibit this issue since it does not check if the interface is managed. 

It's my belief that the Systemd-Resolved plugin should follow the older DNSMasq's precedent and add all known DNS servers even if the interface is unmanaged.
Comment 1 Beniamino Galvani 2017-02-24 13:35:53 UTC
Created attachment 346637 [details] [review]
[PATCH] dns/resolved: consider configuration from unmanaged devices

(In reply to Daniel Ramos from comment #0)
> It's my belief that the Systemd-Resolved plugin should follow the older
> DNSMasq's precedent and add all known DNS servers even if the interface is
> unmanaged.

Yes, makes sense. Patch attached.
Comment 2 Thomas Haller 2017-02-24 18:41:42 UTC
lgtm
Comment 4 Beniamino Galvani 2017-05-19 08:21:02 UTC
*** Bug 782597 has been marked as a duplicate of this bug. ***