After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779070 - glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available
glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal enhancement
: 1.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-22 14:10 UTC by Sebastian Dröge (slomo)
Modified: 2017-02-23 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available (6.10 KB, patch)
2017-02-22 14:10 UTC, Sebastian Dröge (slomo)
none Details | Review
glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available (6.10 KB, patch)
2017-02-22 14:12 UTC, Sebastian Dröge (slomo)
none Details | Review
glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available (6.16 KB, patch)
2017-02-22 14:16 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2017-02-22 14:10:25 UTC
See commit message
Comment 1 Sebastian Dröge (slomo) 2017-02-22 14:10:29 UTC
Created attachment 346444 [details] [review]
glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available

glBlitFramebuffer() is new GLES3/GL3 API. They are probably often
implemented in terms of each other, and glBlitFramebuffer() can
potentially be implemented more flexible. Let's use it if available.

Also it actually works on imx6 with DirectVIV textures.

Based on a patch by Haihua Hu <jared.hu@nxp.com> from
https://github.com/Freescale/meta-freescale/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/
Comment 2 Sebastian Dröge (slomo) 2017-02-22 14:12:40 UTC
Created attachment 346445 [details] [review]
glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available

glBlitFramebuffer() is new GLES3/GL3 API. They are probably often
implemented in terms of each other, and glBlitFramebuffer() can
potentially be implemented more flexible. Let's use it if available.

Also it actually works on imx6 with DirectVIV textures.

Based on a patch by Haihua Hu <jared.hu@nxp.com> from
https://github.com/Freescale/meta-freescale/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/
Comment 3 Sebastian Dröge (slomo) 2017-02-22 14:16:58 UTC
Created attachment 346446 [details] [review]
glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available

glBlitFramebuffer() is new GLES3/GL3 API. They are probably often
implemented in terms of each other, and glBlitFramebuffer() can
potentially be implemented more flexible. Let's use it if available.

Also it actually works on imx6 with DirectVIV textures.

Based on a patch by Haihua Hu <jared.hu@nxp.com> from
https://github.com/Freescale/meta-freescale/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/
Comment 4 Sebastian Dröge (slomo) 2017-02-23 19:57:51 UTC
Attachment 346446 [details] pushed as bfdbdb7 - glmemory: Use glBlitFramebuffer() instead of glCopyTexImage2D() if available