After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779064 - audiobuffersplit: Add drop-last property
audiobuffersplit: Add drop-last property
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
Other All
: Normal enhancement
: 1.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2017-02-22 12:55 UTC by Vivia Nikolaidou
Modified: 2017-02-22 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

audiobuffersplit: Add drop-last property (3.80 KB, patch)
2017-02-22 12:55 UTC, Vivia Nikolaidou
none Details | Review
audiobuffersplit: Add strict-buffer-size property (4.51 KB, patch)
2017-02-22 13:10 UTC, Vivia Nikolaidou
committed Details | Review

Description Vivia Nikolaidou 2017-02-22 12:55:26 UTC
See commit message
Comment 1 Vivia Nikolaidou 2017-02-22 12:55:30 UTC
Created attachment 346435 [details] [review]
audiobuffersplit: Add drop-last property

If set to TRUE, any last audio samples too small to fill a buffer will
be discarded.
Comment 2 Sebastian Dröge (slomo) 2017-02-22 13:01:02 UTC
Review of attachment 346435 [details] [review]:

::: gst/audiobuffersplit/gstaudiobuffersplit.c
@@ +519,3 @@
+        gst_adapter_clear (self->adapter);
+      else
+        gst_audio_buffer_split_output (self, TRUE);

I think it would make sense to call this "strict-buffer-size" or similar, and also do that on discont. So that never ever a buffer with fewer samples is output. If that makes sense at EOS, it also is important in the middle on discont.
Comment 3 Vivia Nikolaidou 2017-02-22 13:10:01 UTC
Created attachment 346438 [details] [review]
audiobuffersplit: Add strict-buffer-size property

If set to TRUE, any last audio samples too small to fill a buffer will
be discarded.
Comment 4 Sebastian Dröge (slomo) 2017-02-22 19:01:59 UTC
Attachment 346438 [details] pushed as 668c440 - audiobuffersplit: Add strict-buffer-size property