After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779013 - only one (older) screenshot in appdata file
only one (older) screenshot in appdata file
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-21 12:33 UTC by Andreas Nilsson
Modified: 2017-03-13 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix the issue (1.26 MB, patch)
2017-03-10 17:19 UTC, Andreas Nilsson
none Details | Review
new patch (1.26 MB, patch)
2017-03-12 12:38 UTC, Andreas Nilsson
none Details | Review
appdata: Add new and more screenshots (1.26 MB, patch)
2017-03-13 22:08 UTC, Marinus Schraal
committed Details | Review

Description Andreas Nilsson 2017-02-21 12:33:48 UTC
Would be nice to show more aspects of Music in GNOME Software (and in other installers that use Appdata), so more screenshots would be nice.
I can try and get some together as a patch.
Comment 1 Marinus Schraal 2017-02-21 14:24:39 UTC
Sure, a patch would be appreciated. I noticed that the current screenshot is even missing an icon in the bottom-right.
Comment 2 Andreas Nilsson 2017-03-10 17:19:49 UTC
Created attachment 347658 [details] [review]
patch to fix the issue

Hosting these screenshots in the gnome git repo, similar to how gnome-music does it.
Comment 3 Marinus Schraal 2017-03-11 00:01:54 UTC
Review of attachment 347658 [details] [review]:

Thanks, looking pretty good.

One thing I noticed is that the no.4 screenshot is slightly larger than the others, could you fix that?

Also these screenshots are from the .22 release, there have been some visual tweaks here and there since then. I guess that's not much of a deal-breaker.
Comment 4 Andreas Nilsson 2017-03-12 12:38:15 UTC
Created attachment 347746 [details] [review]
new patch

This makes screenshot 4 the same size as the others
Comment 5 Andreas Nilsson 2017-03-12 12:40:09 UTC
> Also these screenshots are from the .22 release, there have been some visual tweaks here and there since then. I guess that's not much of a deal-breaker.

Yeah, my main system is still running 3.22. I have another system with 3.23.x running, but it was a bit of work to get the aspect ratio right to begin with, so I think I would rather look into that at a later point.
I can create another patch for 3.24, once it's out the door.
Comment 6 Marinus Schraal 2017-03-13 22:08:04 UTC
Created attachment 347883 [details] [review]
appdata: Add new and more screenshots
Comment 7 Marinus Schraal 2017-03-13 22:12:43 UTC
lgtm, thanks for the patch!

These screenshots are fine, a lot better than what we had.

Attachment 347883 [details] pushed as d4088e8 - appdata: Add new and more screenshots