After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779006 - add a 'nochecks' variant to build with asserts and type checks disabled
add a 'nochecks' variant to build with asserts and type checks disabled
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-21 10:27 UTC by George Kiagiadakis
Modified: 2018-11-03 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstreamer: add a new 'nochecks' variant to disable asserts and type checks (11.01 KB, patch)
2017-02-21 10:27 UTC, George Kiagiadakis 		none Details | Review
gstreamer: add a new 'nochecks' variant to disable asserts and type checks (5.95 KB, patch)
2017-07-31 13:56 UTC, George Kiagiadakis 		none Details | Review
gstreamer: add a new 'nochecks' variant to disable asserts and type checks (6.43 KB, patch)
2018-05-05 10:12 UTC, George Kiagiadakis 		none Details | Review

Description George Kiagiadakis 2017-02-21 10:27:33 UTC 
Created attachment 346308 [details] [review]
gstreamer: add a new 'nochecks' variant to disable asserts and type checks

On low performance devices, it can be useful to disable asserts and checks. Here is a patch to do it. Maybe the same variant could be used to disable asserts also in other libraries at a later time.
Comment 1 George Kiagiadakis 2017-07-31 13:56:01 UTC 
Created attachment 356646 [details] [review]
gstreamer: add a new 'nochecks' variant to disable asserts and type checks

An updated version of the patch that applies to current master; and also fixed to include a necessary change in config.py
Comment 2 George Kiagiadakis 2018-05-05 10:12:21 UTC 
Created attachment 371699 [details] [review]
gstreamer: add a new 'nochecks' variant to disable asserts and type checks

Rebased
Comment 3 Nicolas Dufresne (ndufresne) 2018-05-05 11:45:40 UTC 
Review of attachment 371699 [details] [review]:

Sorry for a so late review, but can't be handle that variant in the gstreamer recipe base class ?
Comment 4 George Kiagiadakis 2018-05-05 12:07:30 UTC 
Yes, but this is not how things are done for other flags. The base class is practically empty.
Comment 5 GStreamer system administrator 2018-11-03 10:22:09 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/cerbero/issues/43.