After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778913 - meson: add tagged-entry resource header to sources
meson: add tagged-entry resource header to sources
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-02-19 16:28 UTC by Ernestas Kulik
Modified: 2017-02-21 05:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: add tagged-entry resource header to sources (899 bytes, patch)
2017-02-19 16:28 UTC, Ernestas Kulik
none Details | Review
meson: add tagged-entry resource header to sources (900 bytes, patch)
2017-02-19 16:30 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2017-02-19 16:28:23 UTC
A dependency issue can be hit with flatpak-builder, where
gd-tagged-entry-resources.h is not generated when compiling
gd-tagged-entry.c. This can be fixed by adding both the source and the
header to the final soures.
Comment 1 Ernestas Kulik 2017-02-19 16:28:27 UTC
Created attachment 346196 [details] [review]
meson: add tagged-entry resource header to sources
Comment 2 Ernestas Kulik 2017-02-19 16:30:53 UTC
Created attachment 346197 [details] [review]
meson: add tagged-entry resource header to sources

A dependency issue can be hit with flatpak-builder, where
gd-tagged-entry-resources.h is not generated when compiling
gd-tagged-entry.c. This can be fixed by adding both the source and the
header to the final sources.
Comment 3 Patrick Griffis (tingping) 2017-02-19 19:14:22 UTC
Review of attachment 346197 [details] [review]:

Looks good
Comment 4 Patrick Griffis (tingping) 2017-02-21 05:08:44 UTC
Attachment 346197 [details] pushed as 068d60c - meson: add tagged-entry resource header to sources