After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778858 - meson: Fix library name of optical-media plugin
meson: Fix library name of optical-media plugin
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-17 22:45 UTC by Jan Alexander Steffens (heftig)
Modified: 2017-02-21 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] meson: Fix library name of optical-media plugin (804 bytes, patch)
2017-02-17 22:45 UTC, Jan Alexander Steffens (heftig) 		none Details | Review
[PATCH] build: Fix library name of optical-media plugin (1.24 KB, patch)
2017-02-19 09:48 UTC, Jan Alexander Steffens (heftig) 		accepted-commit_now Details | Review

Description Jan Alexander Steffens (heftig) 2017-02-17 22:45:08 UTC 
Created attachment 346113 [details] [review]
[PATCH] meson: Fix library name of optical-media plugin

Fix the library name of the optical-media plugin, which was missing a dash.
Comment 1 Juan A. Suarez Romero 2017-02-19 00:09:29 UTC 
Review of attachment 346113 [details] [review]:

Good catch!

But I think it is better to fix the autotools instead, and use "grlopticalmedia" instead of "grloptical-media".


Main reason is that the other plugins that have a dash (metadata-store, local-metadata, or lua-factory) do not use dashes in the generated library file. So we should follow the same rule here.
Comment 2 Jan Alexander Steffens (heftig) 2017-02-19 09:48:42 UTC 
Created attachment 346178 [details] [review]
[PATCH] build: Fix library name of optical-media plugin

Alright, then.
Comment 3 Juan A. Suarez Romero 2017-02-20 12:12:00 UTC 
Review of attachment 346178 [details] [review]:

LGTM
Comment 4 Victor Toso 2017-02-21 07:31:17 UTC 
Seems that git-bz failed to update here or a mistake of my part.

Patch was pushed as 90b3f9f3e0f4ec40fe39d6095d913ba30892dd64