After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778850 - flatpak: Request full access to session bus
flatpak: Request full access to session bus
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks: 777705
 
 
Reported: 2017-02-17 17:04 UTC by Florian Müllner
Modified: 2017-02-25 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flatpak: Request full access to session bus (1.53 KB, patch)
2017-02-17 17:05 UTC, Florian Müllner 		none Details | Review
flatpak: Poke holes for TpRoomList (2.93 KB, patch)
2017-02-19 01:59 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-02-17 17:04:56 UTC 
See patch. It sucks to open up the sandbox like this, but the plan is to ditch telepathy anyway, so this is just temporary.
Comment 1 Florian Müllner 2017-02-17 17:05:02 UTC 
Created attachment 346095 [details] [review]
flatpak: Request full access to session bus

TpRoomList requests to own a random name on the session bus, there's
no way we can make this work with sandboxed bus access :-(
Comment 2 Bastian Ilsø 2017-02-17 21:31:20 UTC 
(In reply to Florian Müllner from comment #1)
> Created attachment 346095 [details] [review] [review]
> flatpak: Request full access to session bus
> 
> TpRoomList requests to own a random name on the session bus, there's
> no way we can make this work with sandboxed bus access :-(

is this patch supposed to be enough to make the TpRoomList work? Even with it applied I still get 

(org.gnome.Polari:3): Gjs-WARNING **: JS ERROR: TelepathyGLib.Error: org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown
_ServerRoomManager<._onAccountStatusChanged/<@resource:///org/gnome/Polari/js/serverRoomManager.js:67:13
main@resource:///org/gnome/Polari/js/main.js:46:5
run@resource:///org/gnome/gjs/modules/package.js:192:25
start@resource:///org/gnome/gjs/modules/package.js:176:5
@<main>:1:146
Comment 3 Florian Müllner 2017-02-17 22:44:38 UTC 
(In reply to Bastian Ilsø from comment #2)
> is this patch supposed to be enough to make the TpRoomList work?

Yes. The flatpak support in builder is still working on-and-off for me, so I've tested with flatpak-builder and a local repo. Are you sure you tested the updated version? Maybe you set up polari to keep running in the background and just closed the window (instead of properly quitting with appmenu->quit or ctrl+q)?
Comment 4 Bastian Ilsø 2017-02-18 15:33:06 UTC 
Review of attachment 346095 [details] [review]:

looks good to me.
Comment 5 Florian Müllner 2017-02-19 01:59:51 UTC 
Created attachment 346167 [details] [review]
flatpak: Poke holes for TpRoomList

For some reason, room lists require their own (uniquified) telepathy
client. Flatpak allows us to use a wildcard for the last name element,
so with a small patch to make telepathy-glib append only a single name
element when uniquifying names, we can poke the necessary hole in the
sandbox.

Yay, I made it work without full bus access!
Comment 6 Bastian Ilsø 2017-02-24 21:20:06 UTC 
Review of attachment 346167 [details] [review]:

looks good to me
Comment 7 Florian Müllner 2017-02-25 15:39:15 UTC 
Attachment 346167 [details] pushed as 0ac15fc - flatpak: Poke holes for TpRoomList