After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778849 - favorites and bookmarks share the same icon
favorites and bookmarks share the same icon
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
3.23.x
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-17 17:02 UTC by Marinus Schraal
Modified: 2017-02-19 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use emblem-favorite-symbolic icon for favorites (1.92 KB, patch)
2017-02-19 19:56 UTC, Michael Catanzaro 		committed Details | Review

Description Marinus Schraal 2017-02-17 17:02:48 UTC 
Confusingly the same icon is used for both favorites and bookmarks. They mean different things in the sense of the whole bookmarks scheme.

* the star in the address bar means: bookmark this (or ... this is a bookmark i guess, but that part is not working?)

* the star with the favorites tag means: this is an extra-special bookmark, it's my favorite

I do not think they should be using the same star icon.
Comment 1 Michael Catanzaro 2017-02-19 19:56:41 UTC 
The following fix has been pushed:
03b5ca5 Use emblem-favorite-symbolic icon for favorites
Comment 2 Michael Catanzaro 2017-02-19 19:56:45 UTC 
Created attachment 346202 [details] [review]
Use emblem-favorite-symbolic icon for favorites

This doesn't match the mockups, but it helps clarify that favorites are
different from other bookmarks. Favorites are your favorite bookmarks!
<3