GNOME Bugzilla – Bug 778843
bookmarks dialog resizable, contents fixed size
Last modified: 2017-12-19 02:35:08 UTC
Created attachment 346086 [details] bookmarks dialog The bookmarks dialog is resizeable (made larger), but the contents are fixed vertically. It would make sense to allow for the tags section to be bigger and show more tags. Right now it scales horizontally, however it only scales the size of the tag and doesn't show more of them.
I'm not likely to have time to look into this soon, unfortunately, and I really don't understand how GTK+ sizing works. :( If anyone wants to submit a patch, it would be much appreciated.
Created attachment 365094 [details] [review] bookmarks: Don't set scrolled window's max-content-height
Review of attachment 365094 [details] [review]: OK, thanks!
This doesn't change the size of the dialog itself, right? Only the scrolled window within it?
(In reply to Michael Catanzaro from comment #4) > This doesn't change the size of the dialog itself, right? Only the scrolled > window within it? Yes and yes. The size of the scrolled window will change when users resize the whole dialog.
OK, great. Feel free to commit it.
Comment on attachment 365094 [details] [review] bookmarks: Don't set scrolled window's max-content-height Pushed to master as commit 4a32a783195b85a819e3ef6530fc5e2b4ba7b049.
Created attachment 365674 [details] [review] fix 4a32a783195b85a819e3ef6530fc5e2b4ba7b049 Sorry, the previous patch doesn't work very well. This patch fixes that. Tested and works at my side.
Review of attachment 365674 [details] [review]: OK. Maybe avoid using a hash in the first line of the commit message, though.
Comment on attachment 365674 [details] [review] fix 4a32a783195b85a819e3ef6530fc5e2b4ba7b049 Modified the commit message and pushed to master as commit bdc9ed9604b7fd1ff238a7d1a0696b207165791c.