After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778841 - Polari tries to login in NICKSERV but IRC server is configured for USERSERV
Polari tries to login in NICKSERV but IRC server is configured for USERSERV
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal critical
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-17 16:06 UTC by Miguel Perez Colino
Modified: 2017-03-04 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
room: Match on "login" to identify a nick as well (9.48 KB, patch)
2017-03-02 01:00 UTC, Florian Müllner 		committed Details | Review

Description Miguel Perez Colino 2017-02-17 16:06:25 UTC 
In NICKSERV the command to login is "identify" with it'sown set of params. 
In USERSERV the command to login is "login <username> <password>".
Polari does not detect the second one
Comment 1 Florian Müllner 2017-03-02 01:00:11 UTC 
Created attachment 347014 [details] [review]
room: Match on "login" to identify a nick as well

Some nick authentication bots are not only not called "NickServ", but
expect a command that is not "identify", sigh. Support some more of them
by matching on "login" as well as "identify" and remember the expected
command - as long as the parameters are still the same, the existing
NickServ support should then start to work for userserv and friends.
Comment 2 Florian Müllner 2017-03-02 01:01:33 UTC 
I should note that so far I only tested that the patch doesn't break NickServ. I'll be in the RH office tomorrow where I can test with userserv.
Comment 3 Bastian Ilsø 2017-03-04 00:46:08 UTC 
Review of attachment 347014 [details] [review]:

i dont have a server to test this with but the patch applies, polari compiles and identifying with nickserv on gnome still works. if you manage to test your patch, then i think this looks good.
Comment 4 Florian Müllner 2017-03-04 21:51:27 UTC 
Attachment 347014 [details] pushed as fce5c77 - room: Match on "login" to identify a nick as well