GNOME Bugzilla – Bug 778819
After selected all text in a text box, changing on-canvas style doesn't affect the dialog style
Last modified: 2018-05-24 17:26:27 UTC
Hi everyone. I didn't find any possible duplicate of this report, so please be patient if my report isn't useful or if it has already been reported. The problem is that changing the entire text box properties from on-canvas settings the Tool Settings pallette isn't updated with on-canvas settings. How to reproduce the issue: 1) Click on "text" tool 2) Select a font size (eg. 50pt) from the tool settings 3) Click on canvas to create text box and start typing text 4) Select all text of the text box (Ctrl + A) 5) Edit the font size from the on-canvas settings (above the text box, NOT in the Text Tool settings), eg. 70pt; -- The text now changes its font size correctly and the right font size number (70pt) appears in the on-canvas font size dropdown menu, but in the Tool Settings pallette it stills remains the previously set "50pt" number 6) Click on the beginning of the text box on-canvas Problem: - Now the on-canvas font size is set to the default value of "50pt", the same that I set BEFORE creating the textbox Expected result: - When I select all text in a textbox and change font style (size, family, etc.) it should change the default font style (settings in the Tool Settings pallette) ----- I know that there is a precise management of the text function in GIMP, but if user selects all text and change font size from on-canvas settings I think it expects to have the same style in all the box, so if user goes to the beginning of the box it should have the same font style of the rest of the box that he previously set. Thank you all for the impressive work you already done (and will do) with this great program. Kind regards, Roberto
I guess that's a duplicate of bug 631934?
I read it but I can't understand if my specific bug is already a part of it... I think the problem is that when the cursor goes to the beginning of the text, the font settings are always set to the default values, in every case (even if user selects all text and change parameters through on-canvas settings). Feel free to mark this as a duplicate of 631934, if you think it is, maybe I could add a comment to that bug report instead of keeping this active. Thanks.
It's a dependency, at least. Bug 631934 is the catch-all "text tool options and on-canvas options don't really play nice together yet".
In any case, I agree with the precise point requested here. I often had this issue myself.
I correct myself. I don't think the styling set in the toolbox should change. This is the default text styling and is not expected to be updated when you update a specific text layer using on-canvas tool GUI. Yet I believe there is still a bug in the behavior you describe because when you select all the text, and set say 70pt, when you move the cursor to the text box, the on-canvas GUI should still display 70pt (yet the tool settings should still say 50pt in your example). To be more accurate, I think the text tool should follow whatever GUI decision taken on the matter by text processors. The fact is that we can't please any use case and I'm sure we can find use cases where you would prefer the current behavior (someone selecting all and changing a text display, but then expecting to continue writing with whatever one's set as the default font and size). But the least we should do is to stick with whatever guidelines are followed in common text editing software. This way, we just keep a consistent text writing workflow across tools. Testing LibreOffice, the logics seems to be: - When the cursor is in a position between different styling, next input will use styling from the previous character. - If this is the first character (either of the whole text, or of the line, i.e. after line feed), next input will use the styling from the next character. What we do wrong in GIMP is only the second guideline. In our case, when we are on the first character of the text, we use the default styling. And worse, when we are on the first character of a line, it seems we use the styling of whatever text was before *at the time the line feed was created*. Ex: - Text options at style A; - Write some text, select it all and set it all to style B; - Go to the line, write some more text. Select this line 2 only and set it to style C. - Add some text at end of line 1: set this piece of text only to style D. Result: go to the start of line 2; the on-canvas GUI shows style A (which is not the style of the line, nor the style of the text just before, nor even the default style. Just completely wrong)! Expected: it should show style C.
I'll have a look at this bug soon because that has been bothering me for a long time as well. :-)
(In reply to Jehan from comment #5) Yes, I agree with you. Maybe the default parameters could remain the same, but the first character bug is really annoying... Thank you (and other developers) for your time. Kind regards, Roberto
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/1055.