After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778816 - pango-utils: Fix non-escaped \r\n line endings in pango_read_line()
pango-utils: Fix non-escaped \r\n line endings in pango_read_line()
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-17 09:29 UTC by Philip Withnall
Modified: 2017-04-08 04:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pango-utils: Fix non-escaped \r\n line endings in pango_read_line() (1.15 KB, patch)
2017-02-17 09:29 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2017-02-17 09:29:51 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2017-02-17 09:29:55 UTC 
Created attachment 346047 [details] [review]
pango-utils: Fix non-escaped \r\n line endings in pango_read_line()

The handling for \r or \r\n line endings in pango_read_line() was
broken. It should have discarded the \r or \r\n, but was only doing this
for \n or \n\r. The condition (c == EOF) could never have been reached.

Coverity ID: 1391696

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Matthias Clasen 2017-04-08 04:13:51 UTC 
Review of attachment 346047 [details] [review]:

ok
Comment 3 Matthias Clasen 2017-04-08 04:55:52 UTC 
Attachment 346047 [details] pushed as 6f06480 - pango-utils: Fix non-escaped \r\n line endings in pango_read_line()