After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778802 - GNOME Flatpak SDK should build mozjs38 for GJS master
GNOME Flatpak SDK should build mozjs38 for GJS master
Status: RESOLVED FIXED
Product: Release Engineering
Classification: Infrastructure
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Philip Chimento
Release Engineering People
Depends on:
Blocks:
 
 
Reported: 2017-02-17 02:24 UTC by Philip Chimento
Modified: 2017-02-23 12:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update to mozjs38 plus patches used in jhbuild (89.47 KB, patch)
2017-02-17 02:25 UTC, Philip Chimento 		none Details | Review

Description Philip Chimento 2017-02-17 02:24:29 UTC 
Here is a patch for gnome-sdk-images to build mozjs38 for GJS master.

I couldn't figure out what product to file this bug under - apologies if this is the wrong one.
Comment 1 Philip Chimento 2017-02-17 02:25:43 UTC 
Created attachment 346036 [details] [review]
Update to mozjs38 plus patches used in jhbuild

Except mozjs38-install-name.patch, which is only needed on macOS.
Comment 2 Alexander Larsson 2017-02-20 08:46:52 UTC 
Review of attachment 346036 [details] [review]:

::: org.gnome.Sdk.json.in
@@ -570,3 @@
                 {
                     "type": "archive",
-                    "url": "http://www.abisource.com/downloads/enchant/1.6.0/enchant-1.6.0.tar.gz",

Eh?
Comment 3 Alexander Larsson 2017-02-20 08:49:46 UTC 
Pushed to master sans the enchant thing.
Comment 4 Philip Chimento 2017-02-21 04:34:11 UTC 
Thanks for removing that. The abisource website was not responding when I was testing this out, hence the edit, and I did commit -a without thinking.
Comment 5 Alexander Larsson 2017-02-21 08:34:18 UTC 
It seems to fail to build on i386:

http://sdkbuilder1.gnome.org/logs/build-2017-02-20-090004/build-gnome-sdk-images-master-i386.txt
Comment 6 Philip Chimento 2017-02-22 04:47:44 UTC 
Ugh. I don't think this is specific to i386, rather, a fault of Mozilla's ill-advised timestamp check on configure vs configure.ac. Since we patch both files in the same patch, it seems to be indeterminate which is patched first.

I had run into it a few times myself, but thought I'd fixed it by listing configure after configure.ac in the patch. Apparently not.

Does flatpak-builder allow for a "touch this file" step in the build manifest? Or maybe we could simply not patch configure.ac at all, so configure would always be newer than configure.ac. (It's not like anyone would be rebuilding mozjs38 from the state in flatpak-builder.)

What do you think?
Comment 7 Alexander Larsson 2017-02-22 09:11:16 UTC 
We can add a source something like:

  {
    "type": "shell",
    "commands": [
        "touch configure"
    ]
  }
Comment 9 Emmanuele Bassi (:ebassi) 2017-02-22 10:54:11 UTC 
Considering that I still cannot build mozjs with jhbuild because of this issue, I honestly doubt this will be enough to cover all cases.
Comment 10 Philip Chimento 2017-02-23 04:18:21 UTC 
Did it work?

In jhbuild we could add a dummy patch that just adds a few blank lines to configure without touching configure.ac, and apply it last in the series?
Comment 11 Alexander Larsson 2017-02-23 07:28:15 UTC 
I dunno if it works every times, as this seems to be a race, but it made it build once at least.
Comment 12 Alexander Larsson 2017-02-23 12:21:57 UTC 
Argh, it didn't help because i touched the wrong configure, it should be js/src/configure.

Lets hope it works this time.