After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778797 - joinDialog: Add some basic key handling to name entry
joinDialog: Add some basic key handling to name entry
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-16 22:39 UTC by Florian Müllner
Modified: 2017-02-18 21:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
joinDialog: Set :activates-default again (1.31 KB, patch)
2017-02-16 22:39 UTC, Florian Müllner 		committed Details | Review
joinDialog: Handle Escape in name entry (1.49 KB, patch)
2017-02-16 22:39 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-02-16 22:39:14 UTC 
See patches.
Comment 1 Florian Müllner 2017-02-16 22:39:19 UTC 
Created attachment 346022 [details] [review]
joinDialog: Set :activates-default again

Since commit 4aec23aacf, the name entry no longer reacts to the
Enter key. It is still unclear what the correct behavior will
be once we implement filtering, for now just making it activate
the default widget again seems the most reasonable.
Comment 2 Florian Müllner 2017-02-16 22:39:25 UTC 
Created attachment 346023 [details] [review]
joinDialog: Handle Escape in name entry

Now that the entry has been changed to a SearchEntry, it consumes
Escape key presses itself for the ::stop-search keybinding signal
rather than letting it bubble up to the dialog. Not being able to
dismiss the dialog via keyboard is inconvenient, so handle Escape
manually to clear the entry if it contains any text, or dismiss
the dialog otherwise.
Comment 3 Bastian Ilsø 2017-02-18 20:45:29 UTC 
Review of attachment 346022 [details] [review]:

looks good to me
Comment 4 Bastian Ilsø 2017-02-18 20:45:42 UTC 
Review of attachment 346023 [details] [review]:

looks good to me
Comment 5 Florian Müllner 2017-02-18 21:08:39 UTC 
Attachment 346022 [details] pushed as 052acc4 - joinDialog: Set :activates-default again
Attachment 346023 [details] pushed as 321640b - joinDialog: Handle Escape in name entry