GNOME Bugzilla – Bug 778793
Fix errors/warnings with latest gjs
Last modified: 2017-02-17 22:37:44 UTC
gjs was rebased to use mozjs38, which is (thankfully!) less forgiving towards errors ...
Created attachment 346005 [details] [review] chatView: Initialize ButtonTag properties early GObject properties may be accessed during construction, so set the backing JS properties before chaining up to the parent.
Created attachment 346006 [details] [review] userTracker: Move let declaration to the right statement
Created attachment 346007 [details] [review] telepathyClient: Use correct property name Whoops. Thankfully the latest gjs started to complain about bloopers like this ...
Created attachment 346008 [details] [review] telepathyClient: Use normal function parameters Latest gjs seems to have problems with using destructuring assignment with the arguments object - we use normal parameter syntax everywhere else, so just switch to that here as well.
Created attachment 346009 [details] [review] chatView: Don't access unset property We attach a timestamp of the last activity to nick tags to decide whether to show corresponding status messages or not. However this monkey-patched property is unset if there hasn't been any activity from the nick - make sure to handle that case properly instead of using an undefined value in a computation.
Created attachment 346014 [details] [review] Initialize properties early Found some more instances of this elsewhere
Created attachment 346015 [details] [review] userTracker: Move let declaration to the right statement
Created attachment 346016 [details] [review] Use correct property names Whoops - same property, different kind of wrong ...
Created attachment 346017 [details] [review] telepathyClient: Use normal function parameters Latest gjs seems to have problems with using destructuring assignment with the arguments object - we use normal parameter syntax everywhere else, so just switch to that here as well.
Created attachment 346018 [details] [review] chatView: Don't access unset property We attach a timestamp of the last activity to nick tags to decide whether to show corresponding status messages or not. However this monkey-patched property is unset if there hasn't been any activity from the nick - make sure to handle that case properly instead of using an undefined value in a computation.
Created attachment 346019 [details] [review] userTracker: Shut up a gjs warning
Review of attachment 346014 [details] [review]: looks good to me.
Review of attachment 346015 [details] [review]: looks good to me
Review of attachment 346016 [details] [review]: looks good to me
Review of attachment 346017 [details] [review]: looks good to me
Review of attachment 346018 [details] [review]: looks good to me
Review of attachment 346019 [details] [review]: looks good to me
Attachment 346014 [details] pushed as a8b549b - Initialize properties early Attachment 346015 [details] pushed as 992ee90 - userTracker: Move let declaration to the right statement Attachment 346016 [details] pushed as 98d4c25 - Use correct property names Attachment 346017 [details] pushed as 1855d15 - telepathyClient: Use normal function parameters Attachment 346018 [details] pushed as cde6b66 - chatView: Don't access unset property Attachment 346019 [details] pushed as 7de0df8 - userTracker: Shut up a gjs warning