After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778773 - Explain the user why running a game failed
Explain the user why running a game failed
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-16 16:29 UTC by Adrien Plazas
Modified: 2017-02-16 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ui: Clean error-display.ui (1.96 KB, patch)
2017-02-16 21:20 UTC, Adrien Plazas
committed Details | Review
ui: Add secondary label to ErrorDisplay (4.11 KB, patch)
2017-02-16 21:20 UTC, Adrien Plazas
committed Details | Review
retro: Add RetroRunner.get_platform_name() (2.59 KB, patch)
2017-02-16 21:20 UTC, Adrien Plazas
committed Details | Review
Make Runner.check_is_valid() return an error message (4.26 KB, patch)
2017-02-16 21:20 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2017-02-16 16:29:18 UTC
There should be some explanation of why a game didn't run.
Comment 1 Adrien Plazas 2017-02-16 21:20:01 UTC
Created attachment 346001 [details] [review]
ui: Clean error-display.ui

Replace 'position', 'xalign' and 'margin-bottom' props by 'valign' and
'spacing', making the code cleaner.
Comment 2 Adrien Plazas 2017-02-16 21:20:09 UTC
Created attachment 346002 [details] [review]
ui: Add secondary label to ErrorDisplay

Add a secondary label to the ErrorDisplay, this will be used in the next
commit to display a message describing the error.
Comment 3 Adrien Plazas 2017-02-16 21:20:17 UTC
Created attachment 346003 [details] [review]
retro: Add RetroRunner.get_platform_name()

This will be used in a subsequent commit to get a displayable platform
name from a Libretro Core Descriptor platform string.
Comment 4 Adrien Plazas 2017-02-16 21:20:25 UTC
Created attachment 346004 [details] [review]
Make Runner.check_is_valid() return an error message

Also display the returned message on the error display page.

This helps the users to better understand why their game doesn't run.