After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778746 - Rename popover is sometimes misplaced
Rename popover is sometimes misplaced
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-02-16 08:21 UTC by Mohammed Sadiq
Modified: 2017-02-17 22:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
filechooserwidget: Fix rename popover position calculation (1.32 KB, patch)
2017-02-16 09:38 UTC, Timm Bäder 		accepted-commit_now Details | Review

Description Mohammed Sadiq 2017-02-16 08:21:24 UTC 
In File chooser dialog, the rename popover is sometimes misplaced.

How to reproduce:
1. Open some application (eg: gedit)
2. Save the opened document (ie, 'Save' button if in gedit)
3. Navigate to some directory having many files/dirs (enough so that the file/folder view is scrollable)
4. Scroll down a little (one or two (or more) items are now hidden above)
5. Right click on some file/folder -> Rename

Result:
The rename popover is placed somewhere not related to the item that is being renamed.

Thanks
Comment 1 Timm Bäder 2017-02-16 09:38:36 UTC 
Created attachment 345930 [details] [review]
filechooserwidget: Fix rename popover position calculation

Since the browse_file_popover is positioned correctly, just convert the
coordinates in the same way we do there.
Comment 2 Matthias Clasen 2017-02-16 14:21:15 UTC 
Review of attachment 345930 [details] [review]:

assuming you've tested this...
Comment 3 Timm Bäder 2017-02-17 17:25:28 UTC 
Pushed as d637b0eeed6d63449777ffdd06de2b9309150142
Comment 4 Daniel Boles 2017-02-17 22:29:05 UTC 
Wow, not only did the popover not appear, but if you scroll too far, then the terminal fills up with this critical, and (e.g.) gedit seems unrecoverable.

> (gedit:1030): Gtk-CRITICAL **: _gtk_widget_captured_event: assertion  'WIDGET_REALIZED_FOR_EVENT (widget, event)' failed

I can confirm that Timm's patch fixes both issues, and pushed it to gtk-3-22:
commit 26cab782cd81f938fda9a49b4187c2a67282f1b6
Comment 5 Daniel Boles 2017-02-17 22:30:18 UTC 
(In reply to Daniel Boles from comment #4)
> Wow, not only did the popover not appear

... if you scroll too far, that is. Otherwise it does appear, but in the wrong place, as reported.
Comment 6 Mohammed Sadiq 2017-02-17 22:35:30 UTC 
bug 776479 may be related to this.