After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778728 - Split up ComposerWidget into two classes
Split up ComposerWidget into two classes
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
master
Other Linux
: Normal normal
: 0.14.0
Assigned To: Michael Gratton
Geary Maintainers
Depends on: 795219
Blocks: 741741
 
 
Reported: 2017-02-16 00:44 UTC by Michael Gratton
Modified: 2020-09-06 03:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Gratton 2017-02-16 00:44:51 UTC
Currently, ComposerWidget is reasonably complex, since it handles not only managing the composed messages themselves, but also editing actions related to the ComposerWebView.

To improve this, the class and its UI file should be split up into two: A ComposerWidget and a ComposerEditor class, the latter including the editor toolbar (bold, italic, etc) and menu, and the ComposerWebView instance, and which manages actions for the toolbar and any related code. Some functionality may also be able to be moved to ComposerWebview, but that should mostly be kept as the interface between the client and WebKit, and not much else. The attachments UI and code should probably remain in ComposerWidget for now, but that aspect of it should get cleaned up a lot anyway when Bug 778727 lands.

This may solve Bug 741741 (if that is even still valid) but also allow removing the focus in/out hacks in subclasses of ComposerContainer.
Comment 1 Michael Gratton 2017-10-11 17:16:16 UTC
WIP branch up at wip/778728-split-composer
Comment 2 Michael Gratton 2018-06-26 04:48:29 UTC
Bump tickets to 0.14 that aren't going to make 0.13.
Comment 3 Michael Gratton 2020-09-06 03:41:24 UTC
Fixed on mainline for 3.37.90/91.