After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778712 - Removing an alarm updates the event even if changes are cancelled
Removing an alarm updates the event even if changes are cancelled
Status: RESOLVED OBSOLETE
Product: gnome-calendar
Classification: Applications
Component: Edit dialog
3.23.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-15 20:48 UTC by Iñigo Martínez
Modified: 2017-11-24 22:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix event update on alarm remove (798 bytes, patch)
2017-02-15 20:48 UTC, Iñigo Martínez
needs-work Details | Review

Description Iñigo Martínez 2017-02-15 20:48:23 UTC
Created attachment 345878 [details] [review]
Fix event update on alarm remove

When editing an event and removing an alarm, the change is applied even if finally the "Cancel" button is pressed.

You can find attached a possible solution to this bug.
Comment 1 Georges Basile Stavracas Neto 2017-03-15 00:29:42 UTC
Review of attachment 345878 [details] [review]:

This patch partially fixes the problem, but introduces another issue:

 - Open an event, remove some alarms
 - Cancel the edit dialog
 - Open the same event

It should display all the alarms again, but it doesn't show the removed ones.
Comment 2 Iñigo Martínez 2017-03-15 09:48:14 UTC
Actually this patch fixes the problem of changes done to alarms applied directly in to the backend. I mean, even if you cancel the changes made to the alarms of a calendar event, they will be applied into the selected calendar.

The behaviour you are describing is a consecuence of more problems in the Edit Dialog. Those problemas are described by another bug report[0], where there is a wider explanation about what is happening with it.

[0] https://bugzilla.gnome.org/show_bug.cgi?id=778713
Comment 3 Georges Basile Stavracas Neto 2017-04-18 12:35:07 UTC
Review of attachment 345878 [details] [review]:

This patch is dangerous. It makes the
Comment 4 Iñigo Martínez 2017-04-18 13:50:11 UTC
As far as I know, and tested, it didn't apply the change until the changes were accepted and manager updated it. Did I miss something?
Comment 5 Georges Basile Stavracas Neto 2017-11-24 22:11:42 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-calendar/issues/114.