After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778678 - gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps
gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-02-15 12:38 UTC by Bastien Nocera
Modified: 2017-02-15 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps (3.20 KB, patch)
2017-02-15 12:38 UTC, Bastien Nocera 		none Details | Review
gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps (3.21 KB, patch)
2017-02-15 15:24 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-02-15 12:38:08 UTC 
.
Comment 1 Bastien Nocera 2017-02-15 12:38:13 UTC 
Created attachment 345820 [details] [review]
gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps

gtk_show_uri_on_window() will pass enough information for Portal helpers
to allow dialogue parenting in Flatpak, gtk_show_uri() won't, so
deprecate it.
Comment 2 Matthias Clasen 2017-02-15 15:08:20 UTC 
Review of attachment 345820 [details] [review]:

::: gtk/gtkshow.c
@@ +40,3 @@
+ * Note that this function is deprecated as it does not pass the necessary
+ * information for helpers to parent their dialog properly when run from
+ * sandboxed applications.

I don't think it really has anything to do with sandboxing per se.
You simply won't get a transient parent relationship if you call gtk_show_uri(), sandbox or not...

But maybe it is more noticable for portals where we generally show 'dialog-like' windows. So, lets just leave it like this.
Comment 3 Bastien Nocera 2017-02-15 15:24:11 UTC 
Created attachment 345839 [details] [review]
gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps

gtk_show_uri_on_window() will pass enough information for Portal helpers
to allow dialogue parenting in Flatpak, gtk_show_uri() won't, so
deprecate it.
Comment 4 Bastien Nocera 2017-02-15 15:25:10 UTC 
Attachment 345839 [details] pushed as 104c9ac - gtkshow: Prefer gtk_show_uri_on_window() which works for sandboxed apps