GNOME Bugzilla – Bug 778664
Add kill-switch setting for user extensions
Last modified: 2017-02-16 00:40:58 UTC
This is a friendlier way of disabling extensions on session failure than resetting the list of enabled extensions. See also the mockup at https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/tweak-tool/tweak-tool-wires.png
Created attachment 345803 [details] [review] extensionSystem: Add kill-switch setting to disable user extensions When gnome-shell fails to start on login, gnome-session tries to re-launch it again with all extensions disabled. This is currently implemented by clearing the list of enabled extensions, which means the user needs to re-enable their extensions manually again. To make this process less annoying, add a single 'kill-switch' setting gnome-session can use without interfering with the user setting.
Created attachment 345804 [details] [review] extensionPrefs: Expose kill-switch While the extension prefs tool is not meant as the primary way for users to configure extensions - that will be Tweak Tool - it still doesn't hurt to expose the extension kill switch to easily turn extensions back on after a session crash.
Review of attachment 345803 [details] [review]: looks good either way ::: js/ui/extensionSystem.js @@ +350,3 @@ function init() { Main.sessionMode.connect('updated', _sessionUpdated); + global.settings.connect('changed::' + DISABLE_USER_EXTENSIONS_KEY, onEnabledExtensionsChanged); shouldn't this be connected in _loadExtensions() for consistency if nothing else?
Review of attachment 345804 [details] [review]: lgtm
Attachment 345803 [details] pushed as 7395aaf - extensionSystem: Add kill-switch setting to disable user extensions Attachment 345804 [details] pushed as 5d07832 - extensionPrefs: Expose kill-switch (In reply to Rui Matos from comment #3) > shouldn't this be connected in _loadExtensions() for consistency if nothing > else? Makes sense to me, fixed.