After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778660 - Don't mix GJS and GObject signal systems
Don't mix GJS and GObject signal systems
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-15 11:00 UTC by Florian Müllner
Modified: 2017-02-16 00:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't mix GJS and GObject signal systems (3.09 KB, patch)
2017-02-15 11:01 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-02-15 11:00:52 UTC 
See patch.
Comment 1 Florian Müllner 2017-02-15 11:01:00 UTC 
Created attachment 345798 [details] [review]
Don't mix GJS and GObject signal systems

GJS implements a basic signal system that allows monkey-patching
JS objects with signal methods resembling the GObject ones. However
it's clearly not a good idea to replace the actual GObject methods,
so use the proper GObject facilities when inheriting from GObject.
Comment 2 Rui Matos 2017-02-15 14:25:41 UTC 
Review of attachment 345798 [details] [review]:

oops. I did a quick double check and it seems these were the only cases at least
Comment 3 Florian Müllner 2017-02-16 00:38:16 UTC 
Attachment 345798 [details] pushed as e08f2a4 - Don't mix GJS and GObject signal systems