After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778655 - pango-font-face: Add NULL checks to list_sizes and list_faces vfuncs
pango-font-face: Add NULL checks to list_sizes and list_faces vfuncs
Status: RESOLVED OBSOLETE
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-15 10:00 UTC by Philip Withnall
Modified: 2018-05-22 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pango-font-face: Add NULL checks to list_sizes and list_faces vfuncs (2.61 KB, patch)
2017-02-15 10:01 UTC, Philip Withnall 		none Details | Review

Description Philip Withnall 2017-02-15 10:00:59 UTC 
Trivial patch to make vfuncs a little safer in the unlikely case of being called with NULL out parameters.
Comment 1 Philip Withnall 2017-02-15 10:01:04 UTC 
Created attachment 345790 [details] [review]
pango-font-face: Add NULL checks to list_sizes and list_faces vfuncs

The vfunc wrappers for list_sizes and list_faces generally don’t do NULL
checks, so the implementations could be called with NULL out pointers
(actually, list_sizes does check n_sizes). Add the missing NULL checks
to implementations of these vfuncs to be safe.

Coverity IDs: 1391712, 1391713, 1391714

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 GNOME Infrastructure Team 2018-05-22 13:21:18 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pango/issues/268.