After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778645 - Make gnome-maps ready for new GJS
Make gnome-maps ready for new GJS
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Philip Chimento
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-15 02:57 UTC by Philip Chimento
Modified: 2017-02-15 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
contextMenu: Avoid double declaration with 'let' (1.25 KB, patch)
2017-02-15 03:02 UTC, Philip Chimento 		accepted-commit_now Details | Review

Description Philip Chimento 2017-02-15 02:57:54 UTC 
Here's a patch for compatibility with the new GJS. (It fixes something which is a syntax error in ES6 but was previously silently accepted.)
Comment 1 Philip Chimento 2017-02-15 03:02:05 UTC 
Created attachment 345774 [details] [review]
contextMenu: Avoid double declaration with 'let'

The following is a syntax error in ES6:

    let a = 'something';
    let a = 'other thing';

Previously GJS would silently accept this, but in GJS 1.48.0 it will be
a syntax error. This fixes the one instance where it happens. In this
case the offending variable was a dummy variable in a destructuring
assignment, so we can just elide the variable.
Comment 2 Mattias Bengtsson 2017-02-15 16:53:49 UTC 
Review of attachment 345774 [details] [review]:

Awesomesauce!
Comment 3 Mattias Bengtsson 2017-02-15 16:58:35 UTC 
Pushed to master.