After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778641 - Make gnome-weather ready for new GJS
Make gnome-weather ready for new GJS
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Philip Chimento
GNOME Weather Maintainer(s)
Depends on: 777962
Blocks:
 
 
Reported: 2017-02-15 01:11 UTC by Philip Chimento
Modified: 2017-02-15 22:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid double declaration with 'let' (1.20 KB, patch)
2017-02-15 01:13 UTC, Philip Chimento 		committed Details | Review
contextMenu: Avoid double declaration with 'let' (1.25 KB, patch)
2017-02-15 03:00 UTC, Philip Chimento 		none Details | Review

Description Philip Chimento 2017-02-15 01:11:04 UTC 
Here's a patch for compatibility with the new GJS. (It fixes something which is a syntax error in ES6 but was previously silently accepted.)
Comment 1 Philip Chimento 2017-02-15 01:13:17 UTC 
Created attachment 345770 [details] [review]
Avoid double declaration with 'let'

The following is a syntax error in ES6:

    let a = 'something';
    let a = 'other thing';

Previously GJS would silently accept this, but in GJS 1.48.0 it will be
a syntax error. This fixes the one instance where it happens.
Comment 2 Philip Chimento 2017-02-15 03:00:49 UTC 
Created attachment 345773 [details] [review]
contextMenu: Avoid double declaration with 'let'

The following is a syntax error in ES6:

    let a = 'something';
    let a = 'other thing';

Previously GJS would silently accept this, but in GJS 1.48.0 it will be
a syntax error. This fixes the one instance where it happens. In this
case the offending variable was a dummy variable in a destructuring
assignment, so we can just elide the variable.
Comment 3 Philip Chimento 2017-02-15 03:01:43 UTC 
Comment on attachment 345773 [details] [review]
contextMenu: Avoid double declaration with 'let'

Sorry, the second patch was intended for a different bug.
Comment 4 Giovanni Campagna 2017-02-15 17:35:02 UTC 
Review of attachment 345770 [details] [review]:

Sure
Comment 5 Philip Chimento 2017-02-15 22:06:49 UTC 
Attachment 345770 [details] pushed as 39c6572 - Avoid double declaration with 'let'