GNOME Bugzilla – Bug 778596
Pre v0.3.4 release fixes
Last modified: 2017-02-14 11:21:37 UTC
:)
Created attachment 345707 [details] [review] lua-factory: _load_goa_data() only if goa is available Let's wrap grl_lua_library_load_goa_data() to be build only if GOA_ENABLED is declared, otherwise we will get -Wunused-function grl-lua-library.c:1746:1: warning: ‘grl_lua_library_load_goa_data’ defined but not used [-Wunused-function] It is also worth to mention that grl_lua_factory_add_goa_source() in grl-lua-factory.c is already wrapped this way. Signed-off-by: Victor Toso <victortoso@redhat.com>
Created attachment 345708 [details] [review] meson: include optional dependencies Optional dependencies are being checked but not included in each plugin and this patch aims to fix that. Renamed DEPS to REQ_DEPS to make clear distinction with newly included OPT_DEPS. The meson.build file for each plugin was updated for completeness. Signed-off-by: Victor Toso <victortoso@redhat.com>
Review of attachment 345707 [details] [review]: LGTM
Review of attachment 345708 [details] [review]: LGTM
Attachment 345707 [details] pushed as 50fe652 - lua-factory: _load_goa_data() only if goa is available Attachment 345708 [details] pushed as a0375ad - meson: include optional dependencies