After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778567 - Use "destructive-action" style in more places
Use "destructive-action" style in more places
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-13 17:50 UTC by Jeremy Bicha
Modified: 2017-02-15 10:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use "destructive-action" style in more places (2.57 KB, patch)
2017-02-13 17:50 UTC, Jeremy Bicha 		none Details | Review
keyboard: Use "destructive-action" style for "Reset All" (1.14 KB, patch)
2017-02-13 19:25 UTC, Jeremy Bicha 		rejected Details | Review
privacy: Use "destructive-action" style for delete btns (1.73 KB, patch)
2017-02-13 19:25 UTC, Jeremy Bicha 		committed Details | Review
privacy: Set destructive-action for confirmation btns only (2.26 KB, patch)
2017-02-14 19:00 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-02-13 17:50:32 UTC 
.
Comment 1 Jeremy Bicha 2017-02-13 17:50:36 UTC 
Created attachment 345648 [details] [review]
Use "destructive-action" style in more places
Comment 2 Jeremy Bicha 2017-02-13 17:52:37 UTC 
This patch depends on the patch from https://bugzilla.gnome.org/778568
Comment 3 Jeremy Bicha 2017-02-13 19:25:13 UTC 
Created attachment 345664 [details] [review]
keyboard: Use "destructive-action" style for "Reset All"
Comment 4 Jeremy Bicha 2017-02-13 19:25:58 UTC 
Created attachment 345665 [details] [review]
privacy: Use "destructive-action" style for delete btns
Comment 5 Bastien Nocera 2017-02-14 18:13:25 UTC 
Review of attachment 345664 [details] [review]:

The button in the confirmation dialogue should have that class, and having an all permanent red button would be quite distracting.
Comment 6 Jeremy Bicha 2017-02-14 19:00:51 UTC 
Created attachment 345750 [details] [review]
privacy: Set destructive-action for confirmation btns only
Comment 7 Jeremy Bicha 2017-02-14 19:01:40 UTC 
That's a good idea so I improved the privacy commit.

It looks like I just missed 3.23.90 though. :(
Comment 8 Bastien Nocera 2017-02-15 10:50:07 UTC 
Please file new bugs especially when fixes span release boundaries, it makes
it easier to reference upstream bug fixes.