After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778552 - Misc fixes
Misc fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: portal-helper
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-13 10:28 UTC by Bastien Nocera
Modified: 2017-02-13 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
portalHelper: Fix runtime warning (939 bytes, patch)
2017-02-13 10:28 UTC, Bastien Nocera 		committed Details | Review
portalHelper: Fix signal arguments (1.17 KB, patch)
2017-02-13 10:28 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-02-13 10:28:14 UTC 
.
Comment 1 Bastien Nocera 2017-02-13 10:28:19 UTC 
Created attachment 345608 [details] [review]
portalHelper: Fix runtime warning

When there is no URI, then the title should be empty, not null:
Gjs-WARNING **: JS ERROR: Error: Argument 'str' (type utf8) may not be null
Comment 2 Bastien Nocera 2017-02-13 10:28:26 UTC 
Created attachment 345609 [details] [review]
portalHelper: Fix signal arguments

How did this work in tests?!
Comment 3 Florian Müllner 2017-02-13 10:47:54 UTC 
Review of attachment 345608 [details] [review]:

Yes
Comment 4 Florian Müllner 2017-02-13 10:48:00 UTC 
Review of attachment 345609 [details] [review]:

Eeks, yes
Comment 5 Bastien Nocera 2017-02-13 10:54:56 UTC 
Attachment 345608 [details] pushed as 98cdd44 - portalHelper: Fix runtime warning
Attachment 345609 [details] pushed as b5bf82b - portalHelper: Fix signal arguments
Comment 6 Michael Catanzaro 2017-02-13 15:12:31 UTC 
(In reply to Bastien Nocera from comment #2)
> How did this work in tests?!

JavaScript works in mysterious ways....