After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778542 - Use UTF-8 encoding for tooltips on files in the "recently used" list
Use UTF-8 encoding for tooltips on files in the "recently used" list
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-02-13 00:31 UTC by ibcoverity
Modified: 2017-02-15 21:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use UTF-8 encoding for tooltips on files in the "recently used" list (1.69 KB, patch)
2017-02-13 00:31 UTC, ibcoverity
committed Details | Review

Description ibcoverity 2017-02-13 00:31:51 UTC
Created attachment 345594 [details] [review]
Use UTF-8 encoding for tooltips on files in the "recently used" list

g_file_get_path() returns the local pathname and it is entirely possible that
this pathname isn't in UTF-8 encoding, but in a different one defined by
G_FILENAME_ENCODING. Using a string in GLib file name encoding rather than
UTF-8 encoding as tooltip text will produce an erroneous output.

Use the parse name instead. This is a UTF-8 string that describes the file
suitable for use in the user interface.
Comment 1 Matthias Clasen 2017-02-14 12:19:39 UTC
Review of attachment 345594 [details] [review]:

looks right
Comment 2 Matthias Clasen 2017-02-15 21:11:30 UTC
Attachment 345594 [details] pushed as c9aadab - Use UTF-8 encoding for tooltips on files in the "recently used" list