Created attachment 345501 [details] [review]
wayland: Keep pointer to cursor sprite on MetaWaylandTabletTool

Created attachment 345502 [details] [review]
wayland: Update tool cursor scale when crossing monitors

This makes tool cursors properly scaled on hidpi.

Review of attachment 345501 [details] [review]:

ok

Review of attachment 345501 [details] [review]:

::: src/wayland/meta-wayland-tablet-tool.c
@@ +398,3 @@
   tool->cursor_surface_destroy_listener.notify = tablet_tool_handle_cursor_surface_destroy;
 
+  tool->default_sprite = meta_cursor_sprite_from_theme (META_CURSOR_CROSSHAIR);

btw, I just noticed that the sprite was being leaked before this change

Review of attachment 345502 [details] [review]:

with the signal disconnection bit fixed, this looks fine

::: src/wayland/meta-wayland-tablet-tool.c
@@ +441,3 @@
     }
 
+  g_signal_handlers_disconnect_by_data (tool->default_sprite, tool);

could easily keep the signal handler id to disconnect here

(In reply to Rui Matos from comment #4)
> Review of attachment 345501 [details] [review] [review]:
> 
> ::: src/wayland/meta-wayland-tablet-tool.c
> @@ +398,3 @@
>    tool->cursor_surface_destroy_listener.notify =
> tablet_tool_handle_cursor_surface_destroy;
>  
> +  tool->default_sprite = meta_cursor_sprite_from_theme
> (META_CURSOR_CROSSHAIR);
> 
> btw, I just noticed that the sprite was being leaked before this change

Yeah... at least this one should be backported to gnome-3-22

Attachment 345501 [details] pushed as a25915f - wayland: Keep pointer to cursor sprite on MetaWaylandTabletTool
Attachment 345502 [details] pushed as 6b384dc - wayland: Update tool cursor scale when crossing monitors