>> core/8021x: add password properties for certificates

the new properties are not freed in finalize().


>> supplicant: set PIN for objects on PKCS#11 tokens


indention at several places:

+                                                 nm_setting_802_1x_get_phase2_client_cert_password_flags (setting),
+                                        error)) {


rest lgtm



pushed several follow-up commits on your branch.

(In reply to Thomas Haller from comment #1)
> >> core/8021x: add password properties for certificates
> 
> the new properties are not freed in finalize().
> 
> 
> >> supplicant: set PIN for objects on PKCS#11 tokens
> 
> 
> indention at several places:
> 
> +                                                
> nm_setting_802_1x_get_phase2_client_cert_password_flags (setting),
> +                                        error)) {
> 
> 

Fixed

> pushed several follow-up commits on your branch.

The commits look fine to me.

> core/8021x: add password properties for certificates

+NM_AVAILABLE_IN_1_8
+const char *           nm_setting_802_1x_get_ca_cert_password        (NMSetting8021x *setting);

These should also be added to libnm.ver.


+       case PROP_PHASE2_CA_CERT_PASSWORD_FLAGS:
+               priv->phase2_ca_cert_password_flags = g_value_get_flags (value);
+               break;
+

Extra line.

The rest LGTM.

b4a976fd1175c2311bd2c2ee6b23345cfd56efd7

Did you only fix this for 802.1x and not for VPN clients?