After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778414 - Broken links in Nautilus README
Broken links in Nautilus README
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-09 21:27 UTC by Jan Tojnar
Modified: 2017-02-24 09:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix broken links in README (1.40 KB, patch)
2017-02-09 21:29 UTC, Jan Tojnar 		needs-work Details | Review
Update links in README (1.67 KB, patch)
2017-02-15 09:37 UTC, Jan Tojnar 		none Details | Review
README: update links (1.67 KB, patch)
2017-02-15 10:14 UTC, Jan Tojnar 		committed Details | Review

Description Jan Tojnar 2017-02-09 21:27:35 UTC 
In README file, there are links to GnomeLove, which was renamed to Newcommers.
Comment 1 Jan Tojnar 2017-02-09 21:29:27 UTC 
Created attachment 345382 [details] [review]
Fix broken links in README
Comment 2 Ernestas Kulik 2017-02-15 09:19:57 UTC 
Review of attachment 345382 [details] [review]:

Thanks for the patch!

Your commit message could use some more words in it. :)
In addition, the links where you only changed the protocol weren’t broken per se, so it would probably be best if you split the patch.
Comment 3 Jan Tojnar 2017-02-15 09:37:38 UTC 
Created attachment 345785 [details] [review]
Update links in README

The links were no longer current – they redirected to https version,
a new version of wiki page, or did not redirect to new version at all.
Comment 4 Jan Tojnar 2017-02-15 09:40:36 UTC 
Would this formulation work better?
Comment 5 Ernestas Kulik 2017-02-15 09:41:57 UTC 
(In reply to Jan Tojnar from comment #4)
> Would this formulation work better?

Yeah, it’s fine with me.
Comment 6 Ernestas Kulik 2017-02-15 10:08:02 UTC 
Review of attachment 345785 [details] [review]:

Forgot one thing: you should structure the subject line like this: “README: update links”.
Comment 7 Jan Tojnar 2017-02-15 10:14:38 UTC 
Created attachment 345795 [details] [review]
README: update links

The links were no longer current – they redirected to https version,
a new version of wiki page, or did not redirect to new version at all.
Comment 8 Ernestas Kulik 2017-02-15 10:16:49 UTC 
Review of attachment 345795 [details] [review]:

LGTM, thanks!
Comment 9 Ernestas Kulik 2017-02-24 09:12:23 UTC 
Attachment 345795 [details] pushed as 5f0bf7c - README: update links