GNOME Bugzilla – Bug 778397
Iosassetsrc lacks orientation
Last modified: 2018-11-03 14:04:47 UTC
Images loaded from the iosassetsrc library are not being oriented. It's unclear why/if the gstjpegdec is not passing along orientation EXIF information (or if such information exists). But this uses the iOS method for getting an asset's orientation and passes it along.
Created attachment 345337 [details] [review] Send tag event in create function
This attachment will actually send the event a few times, because it sends the event whenever reading offset=0. Because typefind and various other elements read the first segment multiple times, this function is called multiple times. That may be undesirable. Let me know what you think.
Created attachment 345341 [details] [review] Send tag event in create function Previous patch was wrong
The EXIF are only parsed by jpegparse, which isn't ranked, and isn't plugged. Should fix this to fix that ;-P
If it is in the EXIF tags, which is not necessarily true I guess. See https://bugzilla.gnome.org/show_bug.cgi?id=626531 for jpegparse
Review of attachment 345341 [details] [review]: ::: sys/applemedia/iosassetsrc.m @@ +317,3 @@ + [GST_IOS_ASSET_SRC_ASSET(src) orientation]), + NULL)); + gst_pad_push_event(gst_element_get_static_pad(GST_ELEMENT(src), "src"), orientation_event); This is leaking the pad, also GST_BASE_SRC_PAD(src) should work You also have to make sure to merge tag lists. If there are any others provided by this element (are there?)
Created attachment 345429 [details] [review] Fix memory leak
Comment on attachment 345429 [details] [review] Fix memory leak Please squash this into the original patch and update/replace the original patch with a fixed version :)
Created attachment 346742 [details] [review] Combo of two prev
attachment 346742 [details] [review] depends on bug 777847
Created attachment 346743 [details] [review] Does not depend on ARC
attachment 346743 [details] [review] does not depend on bug 777847
Review of attachment 346742 [details] [review]: How does this relate to the other patch? The other one seems to be obsolete by this one? ::: sys/applemedia/iosassetsrc.m @@ +310,3 @@ } + if (offset == 0) { offset == 0 might not be enough, better add a boolean to remember if you already did this (and reset that boolean when restarting). In pull mode or if there was a seek at the very beginning, offset will never be 0.
Erm, the review should've been on the other patch without the ARC bits (which are all handled in the other bug, right?)
ARC parts are all done, so let's get a single patch that can be merged here now :)
Nick?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/521.