After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778391 - views: sync header labels' style
views: sync header labels' style
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: Views
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-09 12:14 UTC by Georges Basile Stavracas Neto
Modified: 2017-02-09 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
views: sync header labels' style (7.58 KB, patch)
2017-02-09 12:14 UTC, Georges Basile Stavracas Neto 		none Details | Review
views: sync header labels' style (8.04 KB, patch)
2017-02-09 12:28 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Georges Basile Stavracas Neto 2017-02-09 12:14:51 UTC 
The Week view exposed a bug where we had different
CSS selectors for the exact same label. This made
them look inconsistent, with different colors and
paddings.

Fix that by ensuring they all use the same style
class. The Year view drawing code needed to be
reworked a little.
Comment 1 Georges Basile Stavracas Neto 2017-02-09 12:14:55 UTC 
Created attachment 345307 [details] [review]
views: sync header labels' style
Comment 2 Georges Basile Stavracas Neto 2017-02-09 12:28:42 UTC 
Created attachment 345309 [details] [review]
views: sync header labels' style

The Week view exposed a bug where we had different
CSS selectors for the exact same label. This made
them look inconsistent, with different colors and
paddings.

Fix that by ensuring they all use the same style
class. The Year view drawing code needed to be
reworked a little.
Comment 3 Georges Basile Stavracas Neto 2017-02-09 12:34:50 UTC 
Attachment 345309 [details] pushed as 8f34049 - views: sync header labels' style