After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778379 - gstplayer: Add gst_player_get_state API
gstplayer: Add gst_player_get_state API
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-09 08:33 UTC by Lyon
Modified: 2018-11-03 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for add gst_player_get_state() API (1.49 KB, patch)
2017-02-09 08:36 UTC, Lyon
none Details | Review
Update patch for add get_state API (1.66 KB, patch)
2017-02-09 12:02 UTC, Lyon
none Details | Review

Description Lyon 2017-02-09 08:33:24 UTC
For gstpalyer state, currently we can only get the state by state_change callback, when mainloop start running.

However, if we need to get the current state when mainloop has not started running. There is no way to get the gstplayer state.

So considering add this gst_player_get_state() API to get the current player state.
Comment 1 Lyon 2017-02-09 08:36:59 UTC
Created attachment 345291 [details] [review]
patch for add gst_player_get_state() API
Comment 2 Sebastian Dröge (slomo) 2017-02-09 11:28:35 UTC
Review of attachment 345291 [details] [review]:

Generally looks good

::: gst-libs/gst/player/gstplayer.c
@@ +4363,3 @@
+ *
+ * Gets current GstPlayer state.
+ *

This needs some further documentation though. It's not guaranteed that the state returned is the current state, it might've changed in the meantime already. Can you add something about that?
Comment 3 Lyon 2017-02-09 12:02:33 UTC
Created attachment 345304 [details] [review]
Update patch for add get_state API

Update the function description
Comment 4 Lyon 2017-02-15 09:33:09 UTC
Hi slomo:
      Could you please help review the new patch? Could it be accepted?
Thanks
Lyon
Comment 5 GStreamer system administrator 2018-11-03 14:04:34 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/519.