GNOME Bugzilla – Bug 778373
[PATCH] quick-add-popover: focus entry after calendar selection
Last modified: 2017-02-09 11:50:42 UTC
Created attachment 345283 [details] [review] quick-add-popover: focus entry after calendar selection Pressing 'Enter' key shall always save the event. So focusing on 'Add' button after selecting calendar is redundant. Instead, focus on the entry, so that the user can add more text without manually focusing.
Review of attachment 345283 [details] [review]: I think we can do even better and check if there's anything typed into the event title. If it's empty, we focus it. If there's a title, move the focus to the "Create" button.
(In reply to Georges Basile Stavracas Neto from comment #1) > I think we can do even better and check if there's anything typed into the > event title. If it's empty, we focus it. If there's a title, move the focus > to the "Create" button. I did thought this way first. Later I wrote the way above due to the following reason: if a user presses 'Enter' key when focus is on entry, it behaves the same as clicking 'Create' button. So, if the focus is one 'Create' button the extra feature we get is the 'Space bar' key, which when pressed, shall press the 'Create' button. Though pressing 'Enter' key is a bit harder than hitting 'Space bar' I thought it isn't that worth. Anyway, if you would say otherwise again, I shall re-write my patch. Thanks.
Thanks for the patch! Pushed to master on 02/09/2017, QA ready.