GNOME Bugzilla – Bug 778366
exposure: Absorb dt:exposure
Last modified: 2017-02-09 11:49:05 UTC
If we only consider the 'exposure' property, then gegl:exposure is the same as dt:exposure. One desirable thing about Darktable's version is that it let's us adjust the black level - the threshold at which dark grey values are cut off to pure black [1]. Let's add a property to offer the same feature. If we leave black at its default value of 0.0, the behaviour of gegl:exposure should remain largely unchanged. The only difference is that the value of 'gain' won't exceed 100, while in the past it used to be unbounded. This seems like an acceptable compromise. Also see: commit 4e57ea0ff23d [1] https://www.darktable.org/usermanual/ch03s04.html.php
Created attachment 345272 [details] [review] operations/common/exposure: Add a property for adjusting blacks
Created attachment 345302 [details] [review] Remove dt:exposure
Pushed with pippin's blessing in #gegl on GIMPNet: 21:55 <rishi> mitch: pippin: What do you think: https://bugzilla.gnome.org/show_bug.cgi?id=778366 ? 11:21 <pippin> rishi: probably a good idea, but an srgb argument on it is not... 11:23 <rishi> pippin: Yeah, only added the srgb argument to the dt:exposure in workshop so that I can play with RAW and JPEGs a bit. 11:23 <rishi> Ok, if I push it and delete dt-exposure.c? 11:24 <pippin> sure :) 11:37 <pippin> rishi: i think we can just swap it out - since GIMP probably only exposes it in menus but doesn't wrap APIs for it 11:38 <rishi> pippin: Well, gegl:exposure has an OpenCL implementation.