After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778340 - don't pile up 'My chef information' dialog
don't pile up 'My chef information' dialog
Status: RESOLVED FIXED
Product: recipes
Classification: Other
Component: data
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Recipes maintainer(s)
Recipes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-02-08 13:23 UTC by Mohammed Sadiq
Modified: 2017-02-09 23:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't show a dialog when one is already shown (5.94 KB, patch)
2017-02-08 15:25 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2017-02-08 13:23:52 UTC 
Each time when the user clicks 'My chef information' from Application menu, a new dialog is shown, regardless of whether one is already shown or not. It may be better to not show a new dialog, when one is already shown.

Thanks.
Comment 1 Mohammed Sadiq 2017-02-08 15:25:39 UTC 
Created attachment 345239 [details] [review]
Don't show a dialog when one is already shown

The dialog windows can pile up each time import/chef information
was clicked in applicaton menu.

So, instead of always creating a new dialog, check if there is already one,
and create only if there is none.
Comment 2 Matthias Clasen 2017-02-09 04:32:27 UTC 
Review of attachment 345239 [details] [review]:

Looking at this in some more detail, I'm afraid it is not quite right, and not quite what we need.

1) I don't like the 'is_dialog_open' business. The 'my chef information' and the 'recipe author' dialogs are independent, and I don't think we should prevent the former to be opened on top of the latter.

2) We currently don't handle nested modals right - e.g. try opening the about dialog on top of the my chef information dialog and try to drag the about dialog under gnome shell.

I think the show_chef_dialog api is ok for the app menu case. What we need in addition is something akin to gnome-softwares' gs_shell_modal_dialog_present which keeps a stack of open modals.
Comment 3 Matthias Clasen 2017-02-09 23:55:33 UTC 
Attachment 345239 [details] pushed as 977136e - Don't show a dialog when one is already shown