GNOME Bugzilla – Bug 778334
gst-build: add valgrind support
Last modified: 2018-11-03 11:04:46 UTC
.
Created attachment 345188 [details] [review] add valgrind support Use add_test_setup() which has been introduced in Meson 0.38.
I wonder how add_test_setup() in a superproject and a subproject interact? Can we have both with the same name? Asked differently, shouldn't this be in the gst modules instead?
(In reply to Tim-Philipp Müller from comment #2) > I wonder how add_test_setup() in a superproject and a subproject interact? > Can we have both with the same name? I asked the same question to Jussi on IRC: <jpakkane> cassidy: currently only top level project setups are considered.
Ok, so maybe we should figure this out on the meson side first then.
We should pass --suppressions to valgrind with the list of supp files, so yeah, maybe it should indeed be done in each subproject.
Nirbheek: how should we handle this? Should the valgrind test_setup be duplicated in each gst subproject?
Let's just add it to the gst-build meson.build file for now. I also think we should move the suppressions file to gstreamer.git and install it, just like glib does into /usr/share/gstreamer-1.0/valgrind. This way we can also easily use it in gst-build. Currently it resides in common.git. We also have a bunch of plugin-specific .supp files for -base, good, bad, ugly. What to do about those? AFAIK you cannot specify multiple suppression files to valgrind, so I think we should merge those into gst.supp (and we should also clean up gst.supp a bit; it has some 11-year-old things in it).
(In reply to Nirbheek Chauhan from comment #7) > AFAIK you cannot specify multiple suppression > files to valgrind, so I think we should merge those into gst.supp (and we > should also clean up gst.supp a bit; it has some 11-year-old things in it). Actually you can pass multiple --suppressions=$FILE arguments so each gst component installing its own supp file would make sense. Ideally it would be best to have /usr/lib/valgrind/supp.d/ directory to install those but that's not supported yet: https://bugs.kde.org/show_bug.cgi?id=93376
Oh, that makes sense then. It would actually be really nice then to be able to "associate" suppression files with specific libraries in Meson so that they can be passed automatically to valgrind when running tests in valgrind mode. In the meantime, gst-build can just pass all the suppression files to the valgrind test setup.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-build/issues/4.