After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778333 - Applemedia/AVFVideoSource: Add support for position, device type, and device orientation
Applemedia/AVFVideoSource: Add support for position, device type, and device ...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.11.1
Other Mac OS
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 777847
Blocks:
 
 
Reported: 2017-02-08 11:15 UTC by Nick Kallen
Modified: 2017-03-08 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed implementation (15.68 KB, patch)
2017-02-08 11:24 UTC, Nick Kallen
committed Details | Review
Compile issues on OSX with previous patch (2.51 KB, patch)
2017-03-08 13:20 UTC, Nick Kallen
committed Details | Review

Description Nick Kallen 2017-02-08 11:15:47 UTC
At the moment, the avfvideosrc only takes a device-index to identify which camera. There is a better api that allows you to specify front and rear facing camera, wide angle vs telephoto, etc. Additionally, setting the orientation is useful.
Comment 1 Nick Kallen 2017-02-08 11:24:21 UTC
Created attachment 345187 [details] [review]
Proposed implementation
Comment 2 Nick Kallen 2017-02-08 11:26:52 UTC
Depends on bug 777847
Comment 3 Sebastian Dröge (slomo) 2017-02-26 10:18:07 UTC
Review of attachment 345187 [details] [review]:

Looks good to me, but depends on the ARC patch.


Ideally this should get a GstDeviceMonitor implementation so that the application can know what options are available with a generic API.
Comment 4 Sebastian Dröge (slomo) 2017-03-07 11:39:46 UTC
commit 0968bad8a4bf0681e61c48afbd7962a3a8c9a3cd
Author: Nick Kallen <nickkallen@me.com>
Date:   Wed Feb 8 12:23:09 2017 +0100

    applemedia: avfvideosrc supports position, device-type, and orientation
    
    Avfvideosrc represents an iphone camera or, on mac, a screencapture session.
    The old API allowed you to select an input device by device index only. The new
    API adds the ability to select the position (front or back facing) and
    device-type (wide angle, telephoto, etc.). Furthermore, you can now specify
    the orientation (portrait, landscape, etc.) of the videostream.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=778333
Comment 5 Nick Kallen 2017-03-08 13:20:46 UTC
Created attachment 347483 [details] [review]
Compile issues on OSX with previous patch
Comment 6 Sebastian Dröge (slomo) 2017-03-08 13:24:13 UTC
commit 82c132aa508d5acfa038b509bd6a7f7963118c5f
Author: Nick Kallen <nickkallen@me.com>
Date:   Wed Mar 8 14:16:43 2017 +0100

    applemedia/gl: Fix compile issues for OSX
    
    https://bugzilla.gnome.org/show_bug.cgi?id=778333