After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778299 - Variable-type consistency in gcal-window.c
Variable-type consistency in gcal-window.c
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: Backend
3.22.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-07 17:43 UTC by Yash
Modified: 2017-02-09 12:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gcal-window: Earlier 'view' was declared as a 'guint' but was used as 'gint'. This patch changes the declaration of 'view' to gint32. (815 bytes, patch)
2017-02-07 17:48 UTC, Yash 		needs-work Details | Review
gcal-window: Declare 'view' as type guint32 (846 bytes, patch)
2017-02-09 12:19 UTC, Yash 		committed Details | Review

Description Yash 2017-02-07 17:43:26 UTC 
The variable 'view' was declared as 'guint' but was later used as 'gint'. There is no type consistency in 'view'.
Comment 1 Yash 2017-02-07 17:44:02 UTC 
** in gcal-window.c
Comment 2 Yash 2017-02-07 17:48:17 UTC 
Created attachment 345129 [details] [review]
gcal-window: Earlier 'view' was declared as a 'guint' but was used as 'gint'. This patch changes the declaration of 'view' to gint32.
Comment 3 Georges Basile Stavracas Neto 2017-02-09 11:46:36 UTC 
Review of attachment 345129 [details] [review]:

The commit message needs improvement. The title is huge, and there is no message below. Check [1] to see how the message is expected to be.

[1] https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines
Comment 4 Yash 2017-02-09 12:19:27 UTC 
Created attachment 345308 [details] [review]
gcal-window: Declare 'view' as type guint32

Earlier 'view' was declared as a 'guint' but was used as 'gint'.
This patch changes the declaration of 'view' to gint32.
Comment 5 Georges Basile Stavracas Neto 2017-02-09 12:37:11 UTC 
Thanks for the patch!

Attachment 345308 [details] pushed as 6ce4574 - gcal-window: Declare 'view' as type guint32