After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778266 - Resize the "Add Printer" dialog
Resize the "Add Printer" dialog
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
git master
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-07 09:21 UTC by Felipe Borges
Modified: 2017-02-07 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printers: Resize the "Add Printer" dialog (1.46 KB, patch)
2017-02-07 09:21 UTC, Felipe Borges 		committed Details | Review

Description Felipe Borges 2017-02-07 09:21:24 UTC 
.
Comment 1 Felipe Borges 2017-02-07 09:21:48 UTC 
Created attachment 345087 [details] [review]
printers: Resize the "Add Printer" dialog

In order to keep the dialog size in the same aspect ratio of the
mockups as https://wiki.gnome.org/Design/SystemSettings/Printers

The "height-request" property should never go higher than 490px.

490 is an estimated value for the panels to properly fit on netbook
screens. See https://wiki.gnome.org/Design/SystemSettings#Notes
Comment 2 Marek Kašík 2017-02-07 11:40:28 UTC 
Review of attachment 345087 [details] [review]:

Thank you for the patch. Please push it to master.
Comment 3 Felipe Borges 2017-02-07 11:56:23 UTC 
Attachment 345087 [details] pushed as 1504a4d - printers: Resize the "Add Printer" dialog