After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778236 - Offer to auto switch to fullscreen when starting a game
Offer to auto switch to fullscreen when starting a game
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-06 10:41 UTC by Adrien Plazas
Modified: 2017-02-27 06:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
data: Add the fullscreen key to the gschema (1.11 KB, patch)
2017-02-26 20:32 UTC, Adrien Plazas
committed Details | Review
ui: Save the fullscreen state in the gschema (3.33 KB, patch)
2017-02-26 20:32 UTC, Adrien Plazas
committed Details | Review
data: Add the window-maximized key to the gschema (1.14 KB, patch)
2017-02-27 06:47 UTC, Adrien Plazas
none Details | Review
ui: Save the window's maximized state in the gschema (1.58 KB, patch)
2017-02-27 06:47 UTC, Adrien Plazas
none Details | Review
data: Add window-position window-size keys to gschema (1.22 KB, patch)
2017-02-27 06:47 UTC, Adrien Plazas
none Details | Review
ui: Save window size and position in the gschema (4.17 KB, patch)
2017-02-27 06:50 UTC, Adrien Plazas
none Details | Review

Description Adrien Plazas 2017-02-06 10:41:42 UTC
Currently fullscreen is automatically left when quiting a game, but the user may also want to automatically switch to fullscreen when entering a game.

I see two solutions to this:
- add an option to inconditionally start games fullscreen
- switch to fullscreen if the user left the game in fullscreen

The big difference is whether the way to control this is by the currents ways to switch to fullscreen or via an options in the Preferences window.
Comment 1 Adrien Plazas 2017-02-26 20:32:29 UTC
Created attachment 346767 [details] [review]
data: Add the fullscreen key to the gschema

This will be used in the next commit to save whether the games should be
displayed in full screen or not.
Comment 2 Adrien Plazas 2017-02-26 20:32:35 UTC
Created attachment 346768 [details] [review]
ui: Save the fullscreen state in the gschema

Save whether the games shoud be in fullscreen or not in the gschema and
retrieve this parameter to automatically set the games fullscreen.
Comment 3 Adrien Plazas 2017-02-26 20:36:00 UTC
Attachment 346767 [details] pushed as 06bd7ed - data: Add the fullscreen key to the gschema
Attachment 346768 [details] pushed as cacb833 - ui: Save the fullscreen state in the gschema
Comment 4 Adrien Plazas 2017-02-27 06:47:45 UTC
Created attachment 346790 [details] [review]
data: Add the window-maximized key to the gschema

This will be used in the next commit to save whether the window is
maximized or not and restore it when starting the application.

https://bugzilla.gnome.org/show_bug.cgi?id=779095
Comment 5 Adrien Plazas 2017-02-27 06:47:51 UTC
Created attachment 346791 [details] [review]
ui: Save the window's maximized state in the gschema

Save whether the window is maximized or not in the gschema and retrieve
this parameter to automatically set it back.

https://bugzilla.gnome.org/show_bug.cgi?id=779095
Comment 6 Adrien Plazas 2017-02-27 06:47:57 UTC
Created attachment 346792 [details] [review]
data: Add window-position window-size keys to gschema

These will be used in the next commit to save the position and size of
the window and restore them when starting the application.
Comment 7 Adrien Plazas 2017-02-27 06:50:45 UTC
Created attachment 346793 [details] [review]
ui: Save window size and position in the gschema

Save the size and the position of the window in the gschema and retrieve
these parameters to automatically set them back.
Comment 8 Adrien Plazas 2017-02-27 06:51:51 UTC
Comment on attachment 346790 [details] [review]
data: Add the window-maximized key to the gschema

Attached to the wrong bug by accident.
Comment 9 Adrien Plazas 2017-02-27 06:52:04 UTC
Comment on attachment 346791 [details] [review]
ui: Save the window's maximized state in the gschema

Attached to the wrong bug by accident.
Comment 10 Adrien Plazas 2017-02-27 06:52:08 UTC
Comment on attachment 346792 [details] [review]
data: Add window-position window-size keys to gschema

Attached to the wrong bug by accident.
Comment 11 Adrien Plazas 2017-02-27 06:52:12 UTC
Comment on attachment 346793 [details] [review]
ui: Save window size and position in the gschema

Attached to the wrong bug by accident.