GNOME Bugzilla – Bug 778209
Clearlooks family themes have distorted window buttons
Last modified: 2017-02-05 22:02:55 UTC
Created attachment 344981 [details] A zip containing images showing the difference between the Marco and Metacity handling of Clearlooks Apologies if this has already been reported. I've noticed that Metacity has trouble displaying the window buttons for Clearlooks family themes (Clearlooks, ClearlooksRe, TraditionalOk, Inverted etc). The X for the close button, the square for maximise and the line for minimise appear squashed and fuzzy. I've attached screenshots to illustrate what I mean. I've filed this against Metacity 3.22 but I think it has been an issue for some time, perhaps since 3.16 though I'm afraid I'm not too sure. Unfortunately, I didn't get round to filing a bug report at the time. This is not an issue with any version of Marco, and that includes the GTK+ 3 version of Marco 1.16 so I don't think it's a GTK+ 3 issue per se. However, exactly the same issue occurs with the GTK Window Decorator in Compiz 0.9.x. I'm using Arch Linux with Intel Graphics.
I can not download attachment... :(
Created attachment 344985 [details] Marco Clearlooks
Created attachment 344986 [details] Metacity Clearlooks
I've uploaded the images individually. Do they download ok?
It looks like problem was/is with firefox. I was able to download attachment from google chrome. :)
What theme is used in screenshots? Metacity theme name and also GTK+ theme?
What version of metacity is used? And where to download metacity theme?
That's the TraditionalOk Metacity theme and GTK+ theme in the screenshot.
Theme is available here: https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/TraditionalOk
Oh and that's Metacity 3.22.1.
- Downloaded themes from that link. - Changed gtk+ and metacity theme to TraditionalOk I will attach image with what I see. Do you use that theme from git master or older version?
Created attachment 344987 [details] Metacity 3.22.1, TraditionalOk
I'm using the very latest version of the theme from Master. I just figured what the difference might be. Try setting org.gnome.desktop.wm.preferences titlebar-font to Sans Bold 10 and make sure org.gnome.desktop.wm.preferences titlebar-uses-system-font is false.
Sorry! It didn't occur to me until just now that the font size might be a factor.
Yes, changing font I see similar "effect". Did you use same font with marco?
Yes. I used exactly the same font with Marco.
With regards to the font size in Marco, I tried setting it to lower and lower sizes, going down to size 2. The button images didn't get distorted in the same way they did in Metacity.
Does titlebar height are same?
As near as I can tell, the titlebar heights are exactly the same.
Created attachment 344994 [details] [review] libmetacity: use POS_EXPR_INT for POS_TOKEN_VARIABLE Can you test this patch?
Building now.
I get the following build failure: meta-draw-op.c: In function ‘fill_env’: meta-draw-op.c:77:20: error: ‘MetaDrawInfo {aka const struct _MetaDrawInfo}’ has no member named ‘scale’ env->scale = info->scale;
Can you test with master then?
Or cherry-pick c54fa264dbbf4cf4df45e049778a95bc609f49b8
P.S. if you use irc then there is #gnome-flashback in irc.gnome.org...
Thanks. I couldn't get configure to run from master. ./configure: line 2574: syntax error near unexpected token `git-directory' ./configure: line 2574: `AX_IS_RELEASE(git-directory)' I'll try cherrypicking.
To build master you need autoconf-archive.
Sorry it took me so long! I didn't know about autoconf-archive. Unfortunately, the patch doesn't seem to work for me. I still see the same behaviour with the patched version. I'll try building it again. Thanks for looking into this so quickly by the way.
Are you sure? Patch did work for me with master and I also just tested with 3.22.
I'm an idiot... The build system was overwriting master with the plain old 3.22 source and then building that. I thought I'd told it not to but I hadn't. I've just built master with the patch and it works! Thanks so much for solving this and sorry again about the delays!
Did you try other themes and/or settings? I am interested if there is no extra/new regressions.
I didn't but I will have a look now.
All themes I have display fine with the patched version. The fonts can be shrunk still further and the window buttons will no longer deform so it behaves just like Marco now in the respect. Increasing the font size is also fine. I can't spot any regressions.